<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN">
<html><body>
<p> </p>
<p>On 24.11.2014 18:53, Raghavendra Gowdappa wrote:</p>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px; width:100%">
<pre>----- Original Message -----</pre>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px; width:100%">From: "Xavier Hernandez" <<a href="mailto:xhernandez@datalab.es">xhernandez@datalab.es</a>> To: "Gluster Devel" <<a href="mailto:gluster-devel@gluster.org">gluster-devel@gluster.org</a>>, "Raghavendra Gowdappa" <<a href="mailto:rgowdapp@redhat.com">rgowdapp@redhat.com</a>> Cc: "Emmanuel Dreyfus" <<a href="mailto:manu@netbsd.org">manu@netbsd.org</a>> Sent: Monday, November 24, 2014 11:05:57 PM Subject: Wrong behavior on fsync of md-cache ? Hi, I have an issue in ec caused by what seems an incorrect behavior in md-cache, at least in NetBSD (on linux this doesn't seem to happen). The problem happens when multiple writes are sent in parallel and one of them fails with an error. After the error, an fsync is issued, before all pending writes are completed. The problem is that this fsync request is not propagated through the xlator stack: md-cache automatically answers it with the same error code returned by the last write, but it does not wait for all pending writes to finish.</blockquote>
<pre>Are you sure that fsync is short-circuited in md-cache. Looking at mdc_fsync I can see that fsync is wound down the xlator stack unconditionally.</pre>
<pre> </pre>
</blockquote>
<pre>Well, I didn't looked at the code. I assumed that since disabling md-stat it worked (performace.stat-prefetch off), the problem was there. Sorry.</pre>
<pre> </pre>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px; width:100%">
<pre>write-behind flushes all pending writes before fsync is wound down the xlator stack.</pre>
<pre> </pre>
</blockquote>
<pre>I think the problem is here: the first thing wb_fsync() checks is if there's an error in the fd (wd_fd_err()). If that's the case, the call is immediately unwinded with that error. The error seems to be set in wb_fulfill_cbk(). I don't know the internals of write-back xlator, but this seems to be the problem.</pre>
<pre> </pre>
<pre>I'm not sure why disabling md-cache the problem disappeared. Maybe I've made a mistake and I disabled write-back instead. I'll check it again tomorrow.</pre>
<pre> </pre>
<pre> </pre>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px; width:100%">
<pre>Are you sure fsync is sent by kernel to glusterfs? May be because of a stale stat information kernel never issues fsync? You can load a debug/trace xlator just above io-stats and check whether you get fsync call (you can also dump fuse to glusterfs traffic using --dump-fuse-path=, but its a bingary file and you need a parser to parse that binary data).</pre>
<pre> </pre>
</blockquote>
<pre>I've seen this lines in log file:</pre>
<pre> </pre>
<pre>[2014-11-24 16:18:29.348552] T [fuse-bridge.c:2457:fuse_fsync_resume] 0-glusterfs-fuse: 395: FSYNC 0xbb242268
[2014-11-24 16:18:29.348663] W [fuse-bridge.c:1261:fuse_err_cbk] 0-glusterfs-fuse: 395: FSYNC() ERR => -1 (Disc quota exceeded)</pre>
<pre> </pre>
<pre>There's nothing in between. I assume that this means that the kernel has sent the FSYNC request and someone has returned EDQUOT error immediately (I log a message if FSYNC reaches ec).</pre>
<pre> </pre>
<pre>Xavi</pre>
</body></html>