<div dir="ltr"><div>I do believe "(a)" looks to be the correct way to go.<br><br></div>--Humble<br><div><br><br></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature"><div dir="ltr"><div>--Humble<br></div><br></div></div></div>
<br><div class="gmail_quote">On Sat, Nov 15, 2014 at 4:52 PM, Niels de Vos <span dir="ltr"><<a href="mailto:ndevos@redhat.com" target="_blank">ndevos@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Sat, Nov 15, 2014 at 11:46:46AM +0530, RAGHAVENDRA TALUR wrote:<br>
> I could not reply to this thread yesterday.<br>
> Earlier, test system used to take care of the rebase.<br>
> However, it worked here only after I did a manual<br>
> rebase on my machine and updated gerrit.<br>
<br>
Indeed, and I have noticed that too. I remember being able to just<br>
resubmit the failed regression tests, and the change would be rebased on<br>
top of HEAD of the branch. To me, that also looks a safer way of going<br>
things, (relatively) old patches can be tested easier that way.<br>
<br>
I suspect that this change came with the triggered regression testing,<br>
but I have not checked that. Do others have an opionion on with what<br>
code the regression tests should be executed? Currently I am aware of<br>
two possible ways:<br>
<br>
a. checkout the HEAD of the branch and cherry-pick the change on top<br>
b. checkout the change (use the tree from the time the change was<br>
posted)<br>
<br>
(b) seems to be the current way, my preference would go to (a).<br>
<br>
Please voice your opinions. Thanks,<br>
Niels<br>
_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
<a href="http://supercolony.gluster.org/mailman/listinfo/gluster-devel" target="_blank">http://supercolony.gluster.org/mailman/listinfo/gluster-devel</a><br>
</blockquote></div><br></div>