<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 13, 2014 at 2:00 PM, Shyam <span dir="ltr"><<a href="mailto:srangana@redhat.com" target="_blank">srangana@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">(apologies, last one on the metrics from me :), as I believe it is more about style than actual numbers at a point)<br>
<br>
_maybe_ this is better, and it is pretty close to call now ;)<span class=""><br>
<br>
find -name '*.c' | xargs grep else | wc -l<br></span>
3719<br>
find -name '*.c' | xargs grep else | grep '}' | wc -l<br>
1986<span class=""><br>
find -name '*.c' | xargs grep else | grep -v '}' | wc -l<br></span>
1733</blockquote><div><br></div><div>Without taking sides: the last grep is including else without either { or }.</div><div><br></div><div><pre style="color:rgb(0,0,0)">[~/work/glusterfs]
sh$ git grep '} else {' | wc -l
1331
[~/work/glusterfs]
sh$ git grep 'else {' | grep -v '}' | wc -l
142
</pre></div>So going by just numbers, "} else {" is 10x more common than "}\n else {". I also find that believable based on familiarity of seeing this pattern in the code. Either way, good idea to stick to one and not allow both in future code.</div><div class="gmail_quote"><br></div><div class="gmail_quote">Thanks</div></div></div>