<html><body><div style="font-family: garamond,new york,times,serif; font-size: 12pt; color: #000000"><div>Ah! Warnings are not the same as "errors". :)<br></div><div>Got it.<br></div><div><br></div><div>-Krutika<br></div><div><br></div><hr id="zwchr"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style="border-left: 2px solid #1010FF; margin-left: 5px; padding-left: 5px; color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><b>From: </b>"Krutika Dhananjay" <kdhananj@redhat.com><br><b>To: </b>"FNU Harshavardhana" <fharshav@redhat.com><br><b>Cc: </b>"Gluster Devel" <gluster-devel@gluster.org><br><b>Sent: </b>Monday, September 22, 2014 4:56:43 PM<br><b>Subject: </b>[Gluster-devel] Regarding the coding guidelines script<br><div><br></div><div style="font-family: garamond,new york,times,serif; font-size: 12pt; color: #000000" data-mce-style="font-family: garamond,new york,times,serif; font-size: 12pt; color: #000000;"><div>Hi,<br></div><div><br></div><div>I just ran ./rfc.sh to push my patch our for review and it failed the checkpatch.pl test.<br></div><div><br></div><div>One of the warnings says the following:<br></div><div><br></div><div>WARNING: quoted string split across lines<br>#93: FILE: xlators/cluster/afr/src/afr-self-heal-entry.c:237:<br>+ gf_log (this->name, GF_LOG_DEBUG, "Gfid mismatch "<br>+ "detected for <%s/%s>, %s on %s and %s on %s. "<br><div><br></div></div><div>I am not sure how we can get around this.</div><div>Most of our gf_log() message strings (especially the ones inside nested blocks) will easily exceed 80 columns if this rule is going to be enforced.<br></div><div>Do we really need this check?<br></div><div><br></div><div>-Krutika<br></div></div><br>_______________________________________________<br>Gluster-devel mailing list<br>Gluster-devel@gluster.org<br>http://supercolony.gluster.org/mailman/listinfo/gluster-devel<br></blockquote><div><br></div></div></body></html>