<html><body><div>Niels you are correct. Let me take a look.
<br>
<br>Luis
<br>
<br>
<br>-----Original Message-----
<br>From: Niels de Vos [ndevos@redhat.com]
<br>Received: Monday, 21 Jul 2014, 10:41AM
<br>To: Luis Pabon [lpabon@redhat.com]
<br>CC: Anders Blomdell [anders.blomdell@control.lth.se]; gluster-devel@gluster.org
<br>Subject: Re: [Gluster-devel] Cmockery2 in GlusterFS
<br>
<br></div><br><div>On Mon, Jul 21, 2014 at 04:27:18PM +0200, Anders Blomdell wrote:
<br>> On 2014-07-21 16:17, Anders Blomdell wrote:
<br>> > On 2014-07-20 16:01, Niels de Vos wrote:
<br>> >> On Fri, Jul 18, 2014 at 02:52:18PM -0400, Luis Pabón wrote:
<br>> >>> Hi all,
<br>> >>> A few months ago, the unit test framework based on cmockery2 was
<br>> >>> in the repo for a little while, then removed while we improved the
<br>> >>> packaging method. Now support for cmockery2 (
<br>> >>> <a href="http://review.gluster.org/#/c/7538/">http://review.gluster.org/#/c/7538/</a> ) has been merged into the repo
<br>> >>> again. This will most likely require you to install cmockery2 on
<br>> >>> your development systems by doing the following:
<br>> >>>
<br>> >>> * Fedora/EPEL:
<br>> >>> $ sudo yum -y install cmockery2-devel
<br>> >>>
<br>> >>> * All other systems please visit the following page: <a href="https://github.com/lpabon/cmockery2/blob/master/doc/usage.md#installation">https://github.com/lpabon/cmockery2/blob/master/doc/usage.md#installation</a>
<br>> >>>
<br>> >>> Here is also some information about Cmockery2 and how to use it:
<br>> >>>
<br>> >>> * Introduction to Unit Tests in C Presentation:
<br>> >>> <a href="http://slides-lpabon.rhcloud.com/feb24_glusterfs_unittest.html#/">http://slides-lpabon.rhcloud.com/feb24_glusterfs_unittest.html#/</a>
<br>> >>> * Cmockery2 Usage Guide:
<br>> >>> <a href="https://github.com/lpabon/cmockery2/blob/master/doc/usage.md">https://github.com/lpabon/cmockery2/blob/master/doc/usage.md</a>
<br>> >>> * Using Cmockery2 with GlusterFS: <a href="https://github.com/gluster/glusterfs/blob/master/doc/hacker-guide/en-US/markdown/unittest.md">https://github.com/gluster/glusterfs/blob/master/doc/hacker-guide/en-US/markdown/unittest.md</a>
<br>> >>>
<br>> >>>
<br>> >>> When starting out writing unit tests, I would suggest writing unit
<br>> >>> tests for non-xlator interface files when you start. Once you feel
<br>> >>> more comfortable writing unit tests, then move to writing them for
<br>> >>> the xlators interface files.
<br>> >>
<br>> >> Awesome, many thanks! I'd like to add some unittests for the RPC and NFS
<br>> >> layer. Several functions (like ip-address/netmask matching for ACLs)
<br>> >> look very suitable.
<br>> >>
<br>> >> Did you have any particular functions in mind that you would like to see
<br>> >> unittests for? If so, maybe you can file some bugs for the different
<br>> >> tests so that we won't forget about it? Depending on the tests, these
<br>> >> bugs may get the EasyFix keyword if there is a clear description and
<br>> >> some pointers to examples.
<br>> >
<br>> > Looks like parts of cmockery was forgotten in glusterfs.spec.in:
<br>> >
<br>> > # rpm -q -f `which gluster`
<br>> > glusterfs-cli-3.7dev-0.9.git5b8de97.fc20.x86_64
<br>> > # ldd `which gluster`
<br>> > linux-vdso.so.1 => (0x00007ffff4dfe000)
<br>> > libglusterfs.so.0 => /lib64/libglusterfs.so.0 (0x00007fe034cc4000)
<br>> > libreadline.so.6 => /lib64/libreadline.so.6 (0x00007fe034a7d000)
<br>> > libncurses.so.5 => /lib64/libncurses.so.5 (0x00007fe034856000)
<br>> > libtinfo.so.5 => /lib64/libtinfo.so.5 (0x00007fe03462c000)
<br>> > libgfxdr.so.0 => /lib64/libgfxdr.so.0 (0x00007fe034414000)
<br>> > libgfrpc.so.0 => /lib64/libgfrpc.so.0 (0x00007fe0341f8000)
<br>> > libxml2.so.2 => /lib64/libxml2.so.2 (0x00007fe033e8f000)
<br>> > libz.so.1 => /lib64/libz.so.1 (0x00007fe033c79000)
<br>> > libm.so.6 => /lib64/libm.so.6 (0x00007fe033971000)
<br>> > libdl.so.2 => /lib64/libdl.so.2 (0x00007fe03376d000)
<br>> > libcmockery.so.0 => not found
<br>> > libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fe03354f000)
<br>> > libcrypto.so.10 => /lib64/libcrypto.so.10 (0x00007fe033168000)
<br>> > libc.so.6 => /lib64/libc.so.6 (0x00007fe032da9000)
<br>> > libcmockery.so.0 => not found
<br>> > libcmockery.so.0 => not found
<br>> > libcmockery.so.0 => not found
<br>> > liblzma.so.5 => /lib64/liblzma.so.5 (0x00007fe032b82000)
<br>> > /lib64/ld-linux-x86-64.so.2 (0x00007fe0351f1000)
<br>> >
<br>> > Should I file a bug report or could someone on the fast-lane fix this?
<br>> My bad (installation with --nodeps --force :-()
<br>
<br>Actually, I was not expecting a dependency on cmockery2. My
<br>understanding was that only some temporary test-applications would be
<br>linked with libcmockery and not any binaries that would get packaged in
<br>the RPMs.
<br>
<br>Luis, could you clarify that?
<br>
<br>Thanks,
<br>Niels
<br></div></body></html>