<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><div style=""><br></div><div><br></div><hr id="zwchr"><div style="color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style="color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><b>From: </b>"Pranith Kumar Karampuri" <pkarampu@redhat.com><br><b>To: </b>"Vikhyat Umrao" <vumrao@redhat.com><br><b>Cc: </b>"Niels de Vos" <ndevos@redhat.com>, gluster-devel@gluster.org<br><b>Sent: </b>Wednesday, May 28, 2014 9:12:23 PM<br><b>Subject: </b>Re: [Gluster-devel] [wireshark] TODO features<br><div><br></div><br><div><br></div>----- Original Message -----<br>> From: "Vikhyat Umrao" <vumrao@redhat.com><br>> To: "Niels de Vos" <ndevos@redhat.com><br>> Cc: gluster-devel@gluster.org<br>> Sent: Wednesday, May 28, 2014 3:37:47 PM<br>> Subject: Re: [Gluster-devel] [wireshark] TODO features<br>> <br>> Hi Niels,<br>> <br>> Thanks for all your inputs and help, I have submitted a patch:<br>> <br>> <br>> https://code.wireshark.org/review/1833<br><div><br></div>>I have absolutely no idea how this is supposed to work, but just wanted to ask what will the 'name' variable be if the file name is '<EMPTY>' i.e. RPC_STRING_EMPTY<br><div><br></div><div>Thanks Pranith for brining it in , it is good catch.<br></div><div><br></div><div>With this new patch it will solve this :<br></div><div><a href="http://ur1.ca/hegl3" data-mce-href="http://ur1.ca/hegl3">http://ur1.ca/hegl3</a> <br></div><div><br></div><div>Thanks Niels for your inputs.<br></div></div><div style="color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style="color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><br></div><div style="color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style="color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;">Regards,<br></div><div style="color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style="color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;">Vikhyat<br></div><div style="color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style="color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><br></div><div style="color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style="color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;">>Pranith<br>> <br>> <br>> <br>> <br>> <br>> glusterfs: show filenames in the summary for common procedures<br>> <br>> With this patch we will have filename on the summary for procedures MKDIR,<br>> CREATE and LOOKUP.<br>> <br>> <br>> <br>> <br>> Example output:<br>> <br>> 173 18.309307 192.168.100.3 -> 192.168.100.4 GlusterFS 224 MKDIR V330 MKDIR<br>> Call, Filename: testdir<br>> 2606 36.767766 192.168.100.3 -> 192.168.100.4 GlusterFS 376 LOOKUP V330<br>> LOOKUP Call, Filename: 1.txt<br>> 2612 36.768242 192.168.100.3 -> 192.168.100.4 GlusterFS 228 CREATE V330<br>> CREATE Call, Filename: 1.txt<br><div><br></div>That looks good :-)<br><div><br></div>Pranith<br>> <br>> Thanks,<br>> Vikhyat<br>> <br>> <br>> From: "Niels de Vos" <ndevos@redhat.com><br>> To: "Vikhyat Umrao" <vumrao@redhat.com><br>> Cc: gluster-devel@gluster.org<br>> Sent: Tuesday, April 29, 2014 11:16:20 PM<br>> Subject: Re: [Gluster-devel] [wireshark] TODO features<br>> <br>> On Tue, Apr 29, 2014 at 06:25:15AM -0400, Vikhyat Umrao wrote:<br>> > Hi,<br>> > <br>> > I am interested in TODO wireshark features for GlusterFS :<br>> > I can start from below given feature for one procedure:<br>> > => display the filename or filehandle on the summary for common procedures<br>> <br>> Things to get you and others prepared:<br>> <br>> 1. go to https://forge.gluster.org/wireshark/pages/Todo<br>> 2. login and edit the wiki page, add your name to the topic<br>> 3. clone the wireshark repository:<br>> $ git clone git@forge.gluster.org:wireshark/wireshark.git<br>> (you have been added to the 'wireshark' group, so you should have<br>> push access over ssh)<br>> 4. create a new branch for your testing<br>> $ git checkout -t -b wip/master/visible-filenames upstream/master<br>> 5. make sure you have all the dependencies for compiling Wireshark<br>> (quite a lot are needed)<br>> $ ./autogen.sh<br>> $ ./configure --disable-wireshark<br>> (I tend to build only the commandline tools like 'tshark')<br>> $ make<br>> 6. you should now have a ./tshark executable that you can use for<br>> testing<br>> <br>> <br>> The changes you want to make are in epan/dissectors/packet-glusterfs.c.<br>> For example, start with adding the name of the file/dir that is passed<br>> to LOOKUP. The work to dissect the data in the network packet is done in<br>> glusterfs_gfs3_3_op_lookup_call(). It does not really matter on how that<br>> function gets executed, that is more a thing for an other task (add<br>> support for new procedures).<br>> <br>> In the NFS-dissector, you can see how this is done. Check the<br>> implementation of the dissect_nfs3_lookup_call() function in<br>> epan/dissectors/packet-nfs.c. The col_append_fstr() function achieves<br>> what you want to do.<br>> <br>> Of course, you really should share your changes! Now, 'git commit' your<br>> change with a suitable commit message and do<br>> <br>> $ git push origin wip/master/visible-filenames<br>> <br>> Your branch should now be visible under<br>> https://forge.gluster.org/wireshark/wireshark. Let me know, and I'll<br>> give it a whirl.<br>> <br>> Now you've done the filename for LOOKUP, I'm sure you can think of other<br>> things that make sense to get displayed.<br>> <br>> Do ask questions and send corrections if something is missing, or not<br>> working as explained here. This email should probably get included in<br>> the projects wiki https://forge.gluster.org/wireshark/pages/Home some<br>> where.<br>> <br>> Good luck,<br>> Niels<br>> <br>> <br>> _______________________________________________<br>> Gluster-devel mailing list<br>> Gluster-devel@gluster.org<br>> http://supercolony.gluster.org/mailman/listinfo/gluster-devel<br>> <br></div><div><br></div></div></body></html>