<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, May 12, 2014 at 5:16 PM, Justin Clift <span dir="ltr"><<a href="mailto:justin@gluster.org" target="_blank">justin@gluster.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 13/05/2014, at 1:00 AM, Anand Avati wrote:<br>
> On Mon, May 12, 2014 at 4:39 PM, Justin Clift <<a href="mailto:justin@gluster.org">justin@gluster.org</a>> wrote:<br>
> On 13/05/2014, at 12:27 AM, Anand Avati wrote:<br>
> <snip><br>
> > <a href="http://build.gluster.org/job/regression/build" target="_blank">http://build.gluster.org/job/regression/build</a> - key in the gerrit patch number for the CHANGE_ID field, and click 'Build'.<br>
><br>
> Doesn't that just apply the given change to HEAD of its<br>
> associated branch? eg it won't apply dependent commits<br>
> first?<br>
><br>
> No, this is just for jenkins to run tests and vote on gerrit. Applying a change into HEAD is done by sub/maintainers having commit rights to the project in Gerrit. However Gerrit prevents even a maintainer from committing until there is +2 code review vote and +1 verified vote (no matter who votes - Jenkins or someone else)<br>
<br>
</div></div>Heh, bad wording. Was meaning "doesn't that just test the given<br>
patch applied to HEAD for it's associated branch?". Wasn't meaning<br>
actually committing it back to the repo. ;)<br>
<br>
Thinking about it more, if we're just testing _too many_ things<br>
it's likely only a problem short term. When we get the regression<br>
testing parallelised (soon), then it shouldn't really matter much.</blockquote><div><br></div><div style>Ah, I see what you meant. Specifying a gerrit patch# as CHANGE_ID will apply that patch and all its dependent (unmerged yet) gerrit patches on top of HEAD and run the tests. If test fails, then the entire patch set is voted -1, not just the CHANGE_ID specified.</div>
<div style><br></div><div style><br></div></div></div></div>