<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><div>Thanks Niels for all the inputs sure it will help a lot for a good start.<br></div><div><br></div><div>Regards,<br></div><div>Vikhyat<br></div><div><br></div><hr id="zwchr"><div style="color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style="color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><b>From: </b>"Niels de Vos" <ndevos@redhat.com><br><b>To: </b>"Vikhyat Umrao" <vumrao@redhat.com><br><b>Cc: </b>gluster-devel@gluster.org<br><b>Sent: </b>Tuesday, April 29, 2014 11:16:20 PM<br><b>Subject: </b>Re: [Gluster-devel] [wireshark] TODO features<br><div><br></div>On Tue, Apr 29, 2014 at 06:25:15AM -0400, Vikhyat Umrao wrote:<br>> Hi, <br>> <br>> I am interested in TODO wireshark features for GlusterFS : <br>> I can start from below given feature for one procedure: <br>> => display the filename or filehandle on the summary for common procedures <br><div><br></div>Things to get you and others prepared:<br><div><br></div>1. go to https://forge.gluster.org/wireshark/pages/Todo<br>2. login and edit the wiki page, add your name to the topic<br>3. clone the wireshark repository:<br> $ git clone git@forge.gluster.org:wireshark/wireshark.git<br> (you have been added to the 'wireshark' group, so you should have <br> push access over ssh)<br>4. create a new branch for your testing<br> $ git checkout -t -b wip/master/visible-filenames upstream/master<br>5. make sure you have all the dependencies for compiling Wireshark <br> (quite a lot are needed)<br> $ ./autogen.sh<br> $ ./configure --disable-wireshark<br> (I tend to build only the commandline tools like 'tshark')<br> $ make<br>6. you should now have a ./tshark executable that you can use for <br> testing<br><div><br></div><br>The changes you want to make are in epan/dissectors/packet-glusterfs.c. <br>For example, start with adding the name of the file/dir that is passed <br>to LOOKUP. The work to dissect the data in the network packet is done in <br>glusterfs_gfs3_3_op_lookup_call(). It does not really matter on how that <br>function gets executed, that is more a thing for an other task (add <br>support for new procedures).<br><div><br></div>In the NFS-dissector, you can see how this is done. Check the <br>implementation of the dissect_nfs3_lookup_call() function in <br>epan/dissectors/packet-nfs.c. The col_append_fstr() function achieves <br>what you want to do.<br><div><br></div>Of course, you really should share your changes! Now, 'git commit' your <br>change with a suitable commit message and do<br><div><br></div> $ git push origin wip/master/visible-filenames<br><div><br></div>Your branch should now be visible under <br>https://forge.gluster.org/wireshark/wireshark. Let me know, and I'll <br>give it a whirl.<br><div><br></div>Now you've done the filename for LOOKUP, I'm sure you can think of other <br>things that make sense to get displayed.<br><div><br></div>Do ask questions and send corrections if something is missing, or not <br>working as explained here. This email should probably get included in <br>the projects wiki https://forge.gluster.org/wireshark/pages/Home some <br>where.<br><div><br></div>Good luck,<br>Niels<br></div><div><br></div></div></body></html>