<html><body><div style="font-family: garamond,new york,times,serif; font-size: 12pt; color: #000000"><div>+1. This seems like a better idea.<br></div><div><br></div><div>-Krutika<br></div><div><br></div><hr id="zwchr"><blockquote style="border-left:2px solid #1010FF;margin-left:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><b>From: </b>"Pranith Kumar Karampuri" <pkarampu@redhat.com><br><b>To: </b>"Shyamsundar Ranganathan" <shyamsundarr@gmail.com><br><b>Cc: </b>"Gluster Devel" <gluster-devel@nongnu.org>, "Jeff Darcy" <jdarcy@redhat.com>, "Raghavendra Gowdappa" <rgowdapp@redhat.com>, "Krutika Dhananjay" <kdhananj@redhat.com>, "Krishnan Parthasarathi" <kparthas@redhat.com>, "Ravishankar Narayanankutty" <ranaraya@redhat.com>, "Vijay Bellur" <vbellur@redhat.com><br><b>Sent: </b>Friday, April 4, 2014 1:37:30 PM<br><b>Subject: </b>regarding gluster msg ids<br><div><br></div>hi Shyam,<br> Instead of printing numbers as msg-ids, could we print the stringification of macro itself as the msg-id? Reasons why I feel this is better:<br> - No need to worry about msg-id range segment overlaps as we are not dealing with numbers anymore.<br> - macro re-use in same file will cause compilation error. Different msg-id.h files will have different prefixes for msg-ids so there should not be any collisions across components.<br> - We can choose to give easy-to-remember msg-ids like AFR-SPLIT-BRAIN if we want to. No need to lookup what msg-id means etc.<br><div><br></div>I sent a first-cut patch at: http://review.gluster.org/7398<br><div><br></div>TODO: Remove segment related macros if you guys also like the change.<br><div><br></div>This is one of the messages with and without patch above:<br>[2014-04-04 07:08:53.113969] I [MSGID: glusterfsd_msg_30] [glusterfsd.c:1914:main] 0-glusterd: Started running glusterd version 3git (args: glusterd --debug)<br>[2014-04-04 07:10:49.687053] I [MSGID: 100030] [glusterfsd.c:1914:main] 0-glusterd: Started running glusterd version 3git (args: glusterd --debug)<br><div><br></div><br>Pranith<br></blockquote><div><br></div></div></body></html>