<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">On 04/03/2014 10:19 AM, Atin Mukherjee
      wrote:<br>
    </div>
    <blockquote
      cite="mid:468948989.1233121.1396500548135.JavaMail.zimbra@redhat.com"
      type="cite">
      <div style="font-family: times new roman, new york, times, serif;
        font-size: 12pt; color: #000000">
        <div>Hi Lala,<br>
        </div>
        <div><br>
        </div>
        <div>This has been introduced by my patch  : <a
            moz-do-not-send="true">http://review.gluster.org/7292</a></div>
        <div>I will fix it in sometime.<br>
        </div>
        <div><br>
        </div>
        <div><span name="x"></span>
          <div>Regards,<br>
            Atin Mukherjee<br>
            Senior Software Engineer<br>
            E-9, Extn : 73196, Direct : 08039245196, Mobile:
            +919739491377</div>
          <div>Email - <a class="moz-txt-link-abbreviated" href="mailto:amukherj@redhat.com">amukherj@redhat.com</a><br>
          </div>
          <div><span style="font-family: times new roman,new
              york,times,serif; font-size: small;"
              data-mce-style="font-family: times new roman,new
              york,times,serif; font-size: small;"><img
                moz-do-not-send="true"
src="https://mail.google.com/mail/u/0/?ui=2&amp;ik=5cf9316a4b&amp;view=att&amp;th=1410c09322ad5849&amp;attid=0.1.1&amp;disp=emb&amp;zw&amp;atsh=1"
data-mce-src="https://mail.google.com/mail/u/0/?ui=2&amp;ik=5cf9316a4b&amp;view=att&amp;th=1410c09322ad5849&amp;attid=0.1.1&amp;disp=emb&amp;zw&amp;atsh=1"
                height="53" width="163"></span></div>
        </div>
      </div>
    </blockquote>
    <br>
    Thanks Atin. Here is the wiki page for Coverity and other static
    analysis tools to help you get started.<br>
    <br>
<a class="moz-txt-link-freetext" href="http://www.gluster.org/community/documentation/index.php/Fixing_Issues_Reported_By_Tools_For_Static_Code_Analysis">http://www.gluster.org/community/documentation/index.php/Fixing_Issues_Reported_By_Tools_For_Static_Code_Analysis</a><br>
    <br>
    -Lala<br>
    <blockquote
      cite="mid:468948989.1233121.1396500548135.JavaMail.zimbra@redhat.com"
      type="cite">
      <div style="font-family: times new roman, new york, times, serif;
        font-size: 12pt; color: #000000">
        <div><span name="x"></span><br>
        </div>
        <hr id="zwchr">
        <div
style="color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"
          data-mce-style="color: #000; font-weight: normal; font-style:
          normal; text-decoration: none; font-family:
          Helvetica,Arial,sans-serif; font-size: 12pt;"><b>From: </b>"Lalatendu
          Mohanty" <a class="moz-txt-link-rfc2396E" href="mailto:lmohanty@redhat.com">&lt;lmohanty@redhat.com&gt;</a><br>
          <b>To: </b><a class="moz-txt-link-abbreviated" href="mailto:gluster-devel@nongnu.org">gluster-devel@nongnu.org</a><br>
          <b>Sent: </b>Thursday, April 3, 2014 8:31:37 AM<br>
          <b>Subject: </b>[Gluster-devel] Fwd: New Defects reported by
          Coverity Scan for        GlusterFS<br>
          <div><br>
          </div>
          <br>
          <div class="moz-forward-container"><br>
            <br>
            -------- Original Message --------
            <table class="moz-email-headers-table mceItemTable"
              border="0" cellpadding="0" cellspacing="0">
              <tbody>
                <tr>
                  <th align="RIGHT" nowrap="nowrap" valign="BASELINE">Subject:</th>
                  <td>New Defects reported by Coverity Scan for
                    GlusterFS</td>
                </tr>
                <tr>
                  <th align="RIGHT" nowrap="nowrap" valign="BASELINE">Date:</th>
                  <td>Wed, 02 Apr 2014 13:22:24 -0700</td>
                </tr>
                <tr>
                  <th align="RIGHT" nowrap="nowrap" valign="BASELINE">From:</th>
                  <td><a moz-do-not-send="true"
                      class="moz-txt-link-abbreviated"
                      href="mailto:scan-admin@coverity.com"
                      target="_blank"
                      data-mce-href="mailto:scan-admin@coverity.com">scan-admin@coverity.com</a><br
                      data-mce-bogus="1">
                  </td>
                </tr>
              </tbody>
            </table>
            <br>
            <br>
            <pre>Hi,


Please find the latest report on new defect(s) introduced to GlusterFS found with Coverity Scan.

Defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1195423:  Logically dead code  (DEADCODE)
/cli/src/cli-cmd-parser.c: 1188 in cli_cmd_volume_remove_brick_parse()


________________________________________________________________________________________________________
*** CID 1195423:  Logically dead code  (DEADCODE)
/cli/src/cli-cmd-parser.c: 1188 in cli_cmd_volume_remove_brick_parse()
1182                             ret = -1;
1183                             goto out;
1184                     }
1185             }
1186     
1187             if (wordcount &lt; 4) {
&gt;&gt;&gt;     CID 1195423:  Logically dead code  (DEADCODE)
&gt;&gt;&gt;     Execution cannot reach this statement "ret = -1;".
1188                     ret = -1;
1189                     goto out;
1190             }
1191     
1192             ret = dict_set_int32 (dict, "command", command);
1193             if (ret)


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://scan.coverity.com/projects/987?tab=Overview" target="_blank" data-mce-href="http://scan.coverity.com/projects/987?tab=Overview">http://scan.coverity.com/projects/987?tab=Overview</a>

To unsubscribe from the email notification for new defects, <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://scan5.coverity.com/cgi-bin/unsubscribe.py" target="_blank" data-mce-href="http://scan5.coverity.com/cgi-bin/unsubscribe.py">http://scan5.coverity.com/cgi-bin/unsubscribe.py</a>



</pre>
            <br>
          </div>
          <br>
          <br>
          _______________________________________________<br>
          Gluster-devel mailing list<br>
          <a class="moz-txt-link-abbreviated" href="mailto:Gluster-devel@nongnu.org">Gluster-devel@nongnu.org</a><br>
          <a class="moz-txt-link-freetext" href="https://lists.nongnu.org/mailman/listinfo/gluster-devel">https://lists.nongnu.org/mailman/listinfo/gluster-devel</a><br>
        </div>
        <div><br>
        </div>
      </div>
    </blockquote>
    <br>
  </body>
</html>