<div dir="ltr"><div><div><div>can i suggest that instead, we keep peer probe as is, and rewrite it to call two subcommands <br></div></div><br></div>- peer sniff<br><div>- peer attach<br><br></div><div>That way users that want advanced peer sniffing can do so, without breaking backwards compatibility<br>
</div><div><br><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Apr 3, 2014 at 9:22 PM, Harshavardhana <span dir="ltr"><<a href="mailto:harsha@harshavardhana.net" target="_blank">harsha@harshavardhana.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+1 to Paul's idea - it sounds more friendly from Admin point of view -<br>
also provides consistency with naming schemes.<br>
<div class="HOEnZb"><div class="h5"><br>
On Thu, Apr 3, 2014 at 4:57 PM, Paul Cuzner <<a href="mailto:pcuzner@redhat.com">pcuzner@redhat.com</a>> wrote:<br>
><br>
> I like the idea of making the CLI more semantically correct. ie to drop a<br>
> node from a cluster we use the term detach, so to add a node it should be<br>
> attach.<br>
><br>
> Would a peer probe then be more of a diagnostic command ?<br>
> - ie return whether 24007 is open, perform initial handshake - determine<br>
> gluster version and report back to the admin?<br>
><br>
> This would mean that you could make intelligent decisions about bringing<br>
> nodes into the cluster from the automation platform.<br>
><br>
><br>
> ________________________________<br>
><br>
> From: "Nagaprasad Sathyanarayana" <<a href="mailto:nsathyan@redhat.com">nsathyan@redhat.com</a>><br>
> To: "James" <<a href="mailto:purpleidea@gmail.com">purpleidea@gmail.com</a>><br>
> Cc: <a href="mailto:gluster-devel@nongnu.org">gluster-devel@nongnu.org</a><br>
> Sent: Tuesday, 1 April, 2014 6:01:42 PM<br>
> Subject: Re: [Gluster-devel] Introducing a new option to gluster peer<br>
> command.<br>
><br>
><br>
> On 04/01/2014 08:23 AM, James wrote:<br>
><br>
> On Mon, Mar 31, 2014 at 10:29 PM, Nagaprasad Sathyanarayana<br>
> <<a href="mailto:nsathyan@redhat.com">nsathyan@redhat.com</a>> wrote:<br>
><br>
> In the current design, gluster peer probe does the job of both probing the<br>
> server and adding it to trusted pool. Once the server is added to trusted<br>
> pool, it can be detached usingpeer detach command.<br>
><br>
> Wondering if it makes sense to bring in gluster peer attach command to add<br>
> the server to trusted pool. The peer probe command will only prove the<br>
> server mentioned and tells if it is reachable. It can also be enhanced to do<br>
> some diagnostics such as probing specific ports.<br>
><br>
> Do I understand correctly:<br>
><br>
> gluster peer attach would attach the probing server into the pool it<br>
> is probing, correct?<br>
> If so, and if it is already a member of a pool, could you join two<br>
> different pools together?<br>
> I don't know what the gluster internals implications are, but as long<br>
> as I understand this correctly, then I think it would benefit the<br>
> management side of glusterfs.<br>
><br>
> It would certainly make peering more decentralized, as long as double<br>
> peering or running a simultaneous peer attach and peer probe don't<br>
> cause issues. This last point is very important :)<br>
><br>
><br>
> Cheers,<br>
> James<br>
><br>
> The "gluster peer attach" should work the same way as existing "gluster peer<br>
> probe". The new "gluster peer probe" shall only probe the peer and not add<br>
> it to the trusted pool. When we give peer detach option, I think it would<br>
> be natural to expect a peer attach command.<br>
><br>
> Thanks<br>
> Naga<br>
><br>
> _______________________________________________<br>
> Gluster-devel mailing list<br>
> <a href="mailto:Gluster-devel@nongnu.org">Gluster-devel@nongnu.org</a><br>
> <a href="https://lists.nongnu.org/mailman/listinfo/gluster-devel" target="_blank">https://lists.nongnu.org/mailman/listinfo/gluster-devel</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> Gluster-devel mailing list<br>
> <a href="mailto:Gluster-devel@nongnu.org">Gluster-devel@nongnu.org</a><br>
> <a href="https://lists.nongnu.org/mailman/listinfo/gluster-devel" target="_blank">https://lists.nongnu.org/mailman/listinfo/gluster-devel</a><br>
><br>
<br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Religious confuse piety with mere ritual, the virtuous confuse<br>
regulation with outcomes<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@nongnu.org">Gluster-devel@nongnu.org</a><br>
<a href="https://lists.nongnu.org/mailman/listinfo/gluster-devel" target="_blank">https://lists.nongnu.org/mailman/listinfo/gluster-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Jay Vyas<br><a href="http://jayunit100.blogspot.com" target="_blank">http://jayunit100.blogspot.com</a>
</div>