<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 30, 2013 at 3:54 PM, Eric Blake <span dir="ltr"><<a href="mailto:eblake@redhat.com" target="_blank">eblake@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="im">> Hmm, I don't think so.. strncpy of 255 bytes on to a buffer guaranteed to<br>
> be 256 or higher and also guaranteed to be 0-memset'ed cannot return an<br>
> invalid file name. No?<br>
<br>
</div>The fact that your internal glfs_readdir buffer is memset means you are<br>
safe there for a 255-byte filename; but that safety does not extend to<br>
glfs_readdir_r for a user buffer.</blockquote></div><br>Right! Fixed - <a href="http://review.gluster.org/#/c/6201/">http://review.gluster.org/#/c/6201/2</a></div></div>