<div dir="ltr">Hi David,<div><br></div><div>Thanks for reporting looks like it was a blatant mistake on our side, since we never used these functions these issues were not exposed. Sending a follow up fix.</div><div><br></div>
<div>Thanks again</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Oct 18, 2013 at 12:57 PM, David Binderman <span dir="ltr"><<a href="mailto:dcb314@hotmail.com" target="_blank">dcb314@hotmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello there,<br>
<br>
I just ran the static analysis tool "cppcheck" over the source<br>
code of glusterfs-3.4.1<br>
<br>
It said many things, including<br>
<br>
1.<br>
<br>
> dict.c:916:2: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]<br>
<br>
Source code is<br>
<br>
if ((SHRT_MAX> value) || (SHRT_MIN < value)) {<br>
<br>
Maybe something like<br>
<br>
if ((SHRT_MAX < value) || (SHRT_MIN> value)) {<br>
<br>
was intended.<br>
<br>
2.<br>
<br>
> dict.c:948:2: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]<br>
<br>
Duplicate.<br>
<br>
Regards<br>
<span class="HOEnZb"><font color="#888888"><br>
David Binderman<br>
_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@nongnu.org">Gluster-devel@nongnu.org</a><br>
<a href="https://lists.nongnu.org/mailman/listinfo/gluster-devel" target="_blank">https://lists.nongnu.org/mailman/listinfo/gluster-devel</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><i style="font-family:arial;font-size:small">Religious confuse piety with mere ritual, the virtuous confuse regulation with outcomes</i><br>
</div>
</div>