<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jun 14, 2013 at 1:40 AM, Bharata B Rao <span dir="ltr"><<a href="mailto:bharata.rao@gmail.com" target="_blank">bharata.rao@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Mon, Jun 3, 2013 at 9:12 PM, Anand Avati <<a href="mailto:anand.avati@gmail.com">anand.avati@gmail.com</a>> wrote:<br>
> This looks more like a compile time feature check than runtime. The<br>
> PKG_CONFIG() api number which had the initial set of QEMU requirements was 3<br>
> (i.e, PKG_CONFIG(..,glusterfs-api>=3,..). The new updates for Samba<br>
> requirements has api number 4. Depending on whether discard support makes it<br>
> before the next release (and api numbers gets published) or not,<br>
> glfs_discard() would either be available in 4 or 5. Also, you might also<br>
> want to add a second AC_CHECK_FUNC macro in <a href="http://configure.ac" target="_blank">configure.ac</a> to be doubly sure.<br>
<br>
</div>Now with fallocate and discard support upstream, are you planning to<br>
increment the glusterfs-api version ? I still see the version as 4 in<br>
the git master. I need to decide if I should use version 4 or 5 to<br>
determine the availability of discard support from QEMU.<br></blockquote><div><br></div><div><br></div><div style>This is yet to be determined. The fallocate/discard introduces change in the internal protocol/rpc and we're figuring out the right time to bring this patch into a release branch. Since release-3.4 is still "unreleased" there is a possibility, but we have not yet decided on it.</div>
<div style><br></div><div style>Avati <br></div></div></div></div>