<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, May 25, 2013 at 4:23 AM, Andrew Bartlett <span dir="ltr"><<a href="mailto:abartlet@samba.org" target="_blank">abartlet@samba.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Sat, 2013-05-25 at 05:30 -0400, Anand Avati wrote:<br>
> Implement a Samba VFS plugin for glusterfs based on gluster's gfapi.<br>
> This is a "bottom" vfs plugin (not something to be stacked on top of<br>
> another module), and translates (most) calls into closest actions<br>
> on gfapi.<br>
<br>
</div><div class="im">> + if conf.CHECK_HEADERS('api/glfs.h'):<br>
> + conf.DEFINE('HAVE_GLUSTERFS', '1')<br>
> +<br>
> default_static_modules.extend(TO_LIST('''pdb_smbpasswd pdb_tdbsam pdb_wbc_sam<br>
> auth_sam auth_unix auth_winbind auth_wbc<br>
> auth_domain auth_builtin vfs_default<br>
> @@ -1797,6 +1800,9 @@ main() {<br>
> if conf.CONFIG_SET("HAVE_CEPH"):<br>
> default_shared_modules.extend(TO_LIST('vfs_ceph'))<br>
><br>
> + if conf.CONFIG_SET('HAVE_GLUSTERFS'):<br>
> + default_shared_modules.extend(TO_LIST('vfs_glusterfs'))<br>
> +<br>
> explicit_shared_modules = TO_LIST(Options.options.shared_modules, delimiter=',')<br>
> explicit_static_modules = TO_LIST(Options.options.static_modules, delimiter=',')<br>
<br>
</div>I installed glusterfs-devel on my Fedora 18 system, but didn't get<br>
api/glfs.h anywhere. It also seems unlikely that such header name would<br>
be in the default search path, so I'm wondering should we be using some<br>
pkg-config search to find where that would be?<br></blockquote><div><br></div><div style>The patch does have pkg-config integration in <a href="http://configure.in">configure.in</a>. I'm not sure about the waf build or how it works, so I just copied waf changes from other patches, and may well be broken :( Any help in fixing the waf changes will be helpful!</div>
<div style><br></div><div style>Avati</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
I wanted to at least compile this locally before I put my review<br>
blessing on it, which I was otherwise ready to do, as my other concerns<br>
are addressed.<br>
<br>
Thanks,<br>
<div class="im HOEnZb"><br>
Andrew Bartlett<br>
<br>
--<br>
Andrew Bartlett <a href="http://samba.org/~abartlet/" target="_blank">http://samba.org/~abartlet/</a><br>
Authentication Developer, Samba Team <a href="http://samba.org" target="_blank">http://samba.org</a><br>
<br>
<br>
<br>
</div><div class="HOEnZb"><div class="h5">_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@nongnu.org">Gluster-devel@nongnu.org</a><br>
<a href="https://lists.nongnu.org/mailman/listinfo/gluster-devel" target="_blank">https://lists.nongnu.org/mailman/listinfo/gluster-devel</a><br>
</div></div></blockquote></div><br></div></div>