<div dir="ltr"><div><div>Hi,<br><br></div>Thanks, both. I did indeed not do 'git commit -s', and after adding signed off with git commit --amend, rfc.sh worked.<br><br><a href="http://review.gluster.org/#/c/5034/">http://review.gluster.org/#/c/5034/</a><br>
<br><br></div>Regards,<br><br><br>John Smith.<br><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, May 19, 2013 at 3:11 AM, Michael Brown <span dir="ltr"><<a href="mailto:michael@netdirect.ca" target="_blank">michael@netdirect.ca</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="line-height:initial"><div style="text-align:initial;color:rgb(31,73,125);font-size:initial;width:100%;font-family:Calibri,'Slate Pro',sans-serif">
.. and to fix it, do: 'git commit --amend' and add the appropriate Signed-off-by: as you see in other commits in the repo.</div><div style="text-align:initial;color:rgb(31,73,125);font-size:initial;width:100%;font-family:Calibri,'Slate Pro',sans-serif">
<br></div><div style="text-align:initial;color:rgb(31,73,125);font-size:initial;width:100%;font-family:Calibri,'Slate Pro',sans-serif">M.</div> <div style="text-align:initial;color:rgb(31,73,125);font-size:initial;width:100%;font-family:Calibri,'Slate Pro',sans-serif">
<br style="display:initial"></div> <div style="text-align:initial;color:rgb(31,73,125);font-size:initial;font-family:Calibri,'Slate Pro',sans-serif">
-- <br>Michael Brown | `One of the main causes of the fall of<br>Systems Consultant | the Roman Empire was that, lacking zero,<br>Net Direct Inc. | they had no way to indicate successful<br>
☎: <a href="tel:%2B1%20519%20883%201172%20x5106" value="+15198831172" target="_blank">+1 519 883 1172 x5106</a> | termination of their C programs.' - Firth<br></div> <table style="border-spacing:0px" width="100%">
<tbody><tr><td colspan="2" style="text-align:initial;font-size:initial"> <div style="border-style:solid none none;border-top-color:rgb(181,196,223);border-top-width:1pt;padding:3pt 0in 0in;font-family:Tahoma,'BB Alpha Sans','Slate Pro';font-size:10pt">
<div><b>From: </b>Justin Clift</div><div><b>Sent: </b>Saturday, May 18, 2013 21:06</div><div><b>To: </b>John Smith</div><div><b>Reply To: </b>Justin Clift</div><div><b>Cc: </b>Gluster Devel</div><div><b>Subject: </b>Re: [Gluster-devel] Setting up git / gerrit / rfc.sh</div>
</div></td></tr></tbody></table><div style="border-top-color:rgb(186,188,209);text-align:initial;font-size:initial;border-style:solid none none;border-top-width:1pt"></div><br><div><div><div class="h5">On 19/05/2013, at 5:03 AM, John Smith wrote:<br>
<snip><br>> ! [remote rejected] HEAD -> refs/for/master/bug-962226 (not<br>> Signed-off-by author/committer/uploader in commit message footer)<br><br>The "not Signed-off-by xxx" bit sounds like the problem. Guess you<br>
forgot to do a "signed commit" instead of normal commit?<br><br>ie:<br><br> $ git commit -s<br><br>instead of<br><br> $ git commit<br><br>+ Justin<br><br>--<br>Open Source and Standards @ Red Hat<br><br><a href="http://twitter.com/realjustinclift" target="_blank">twitter.com/realjustinclift</a><br>
<br><br></div></div>_______________________________________________<br>Gluster-devel mailing list<br><a href="mailto:Gluster-devel@nongnu.org" target="_blank">Gluster-devel@nongnu.org</a><br><a href="https://lists.nongnu.org/mailman/listinfo/gluster-devel" target="_blank">https://lists.nongnu.org/mailman/listinfo/gluster-devel</a><br>
</div></div>
</blockquote></div><br></div>