<br><br><div class="gmail_quote">On Wed, Jan 23, 2013 at 3:08 AM, Raghavendra Bhat <span dir="ltr"><<a href="mailto:rabhat@redhat.com" target="_blank">rabhat@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<br>
Hi,<br>
<br>
syncop_opendir_cbk does not ref the fd while returning unlike
syncop_open_cbk which results in crash due to fd being destroyed
early and then being accessed (bug 885008). A patch has been
submitted for review. (
<a href="http://review.gluster.org/#change,4282" target="_blank">http://review.gluster.org/#change,4282</a>).
Please review it and provide inputs.<br>
<br></div></blockquote><div><br></div><div>Doing the extra fd_ref() in syncop_open[dir]_cbk seems to be uglier than thought. I see that it is already resulting in fd ref leak in gfapi. It is safer to remove the extra ref/unref and make open[dir]() return only success or failure with op_ret.</div>
<div><br></div><div>Avati </div></div>