I was thinking more of the case where no backup server is configured.<div>If the primary server fails, and a backup is not defined, then found=0 and err=0.</div><div>So, the script will eventually exit with a 0 when it really should have exited with a 1.</div>
<div><br></div><div>dcm<br><br><div class="gmail_quote">On Mon, Jun 27, 2011 at 8:27 AM, Jeff Darcy <span dir="ltr"><<a href="mailto:jdarcy@redhat.com">jdarcy@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On 06/27/2011 08:09 AM, Devon Miller wrote:<br>
> Mind you I haven't looked at this patch in context of the<br>
> xlators/mount/fuse/utils/<a href="http://mount.glusterfs.in" target="_blank">mount.glusterfs.in</a><br>
</div>> <<a href="http://mount.glusterfs.in/" target="_blank">http://mount.glusterfs.in/</a>> file, I've just looked at the patch<br>
<div class="im">> itself. However, it looks like *err* can only be set if *cmd_line1*<br>
> is defined.<br>
<br>
</div>Then $err will remain at its previous value (from above the patch) of 0.<br>
I guess this could be problematic if the first invocation of glusterfs<br>
populated the mount table and subsequently threw an error - almost the<br>
exact opposite of the problem we have now. In that case it would make<br>
sense to check the error code *and* the mount-table contents, but I<br>
don't see that as critical.<br>
</blockquote></div><br></div>