<br><br><div class="gmail_quote">On Tue, Sep 28, 2010 at 1:18 AM, noah williamsson <span dir="ltr"><<a href="mailto:noah.williamsson@gmail.com">noah.williamsson@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
2010/9/27 Amar Tumballi <<a href="mailto:amar@gluster.com">amar@gluster.com</a>>:<br>
<div class="im">> How about having<br>
><br>
> #define FNM_EXTMATCH 0<br>
><br>
> in #ifdef DARWIN_OS section of 'libglusterfs/src/compat.h' file??<br>
><br>
> Idea is to have as less as possible OS specific code inside core, and handle<br>
> maximum possible things in compat.{c,h}<br>
><br>
<br>
</div>That would indeed be more elegant, however, given the fact that<br>
FNM_EXTMATCH is a GNU fnmatch() extension, maybe it should be<br>
considered to get rid of its use completely to get a consistent<br>
behavior across different OSes?<br>
<div class="im"><br></div></blockquote></div><br>That was thought of.. Will check with the team again, and resolve this. Better is to remove GNU specific flags from 'fnmatch()'. <br><br>-Amar<br>