How about having <br><br>#define FNM_EXTMATCH 0<br><br>in #ifdef DARWIN_OS section of 'libglusterfs/src/compat.h' file??<br><br>Idea is to have as less as possible OS specific code inside core, and handle maximum possible things in compat.{c,h}<br>
<br>-Amar<br><br><div class="gmail_quote">On Mon, Sep 27, 2010 at 6:47 PM, Noah Williamsson <span dir="ltr"><<a href="mailto:noah.williamsson@gmail.com">noah.williamsson@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
Signed-off-by: Noah Williamsson <<a href="mailto:noah.williamsson@gmail.com">noah.williamsson@gmail.com</a>><br>
---<br>
libglusterfs/src/xlator.c | 5 +++++<br>
1 files changed, 5 insertions(+), 0 deletions(-)<br>
<br>
diff --git a/libglusterfs/src/xlator.c b/libglusterfs/src/xlator.c<br>
index 3930880..2e48f75 100644<br>
--- a/libglusterfs/src/xlator.c<br>
+++ b/libglusterfs/src/xlator.c<br>
@@ -375,8 +375,13 @@ _volume_option_value_validate (xlator_t *xl,<br>
<br>
for (i = 0; (i < ZR_OPTION_MAX_ARRAY_SIZE) &&<br>
opt->value[i]; i++) {<br>
+#ifdef GF_DARWIN_HOST_OS<br>
+ if (fnmatch (opt->value[i], pair->value->data,<br>
+ 0) == 0) {<br>
+#else<br>
if (fnmatch (opt->value[i], pair->value->data,<br>
FNM_EXTMATCH) == 0) {<br>
+#endif<br>
ret = 0;<br>
break;<br>
}<br>
<font color="#888888">--<br>
1.6.6.1<br>
<br>
<br>
_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@nongnu.org">Gluster-devel@nongnu.org</a><br>
<a href="http://lists.nongnu.org/mailman/listinfo/gluster-devel" target="_blank">http://lists.nongnu.org/mailman/listinfo/gluster-devel</a><br>
</font></blockquote></div><br>