Resending from official email id.<br><br><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Raghavendra G</b> <span dir="ltr"><<a href="mailto:raghavendra.hg@gmail.com">raghavendra.hg@gmail.com</a>></span><br>
Date: Mon, May 18, 2009 at 12:53 PM<br>Subject: Re: [Gluster-devel] [PATCH 3/4] mod_glusterfs/apache/2.2: Added -L$(libdir) to ${APXS} args.<br>To: <a href="mailto:matsuu@gmail.com">matsuu@gmail.com</a><br>Cc: <a href="mailto:Gluster-devel@nongnu.org">Gluster-devel@nongnu.org</a>, MATSUU Takuto <<a href="mailto:matsuu@gentoo.org">matsuu@gentoo.org</a>><br>
<br><br>Hi Matsuu,<br><br>Thanks for submitting a patch.<br><br>The reason why we did not add $(libdir) to the list of directories being searched for libglusterfsclient.so is that mod_glusterfs will always be in sync with the libglusterfsclient that is being built along with it but there is no guarantee that it will be in sync with the already installed version (as specified by adding -L$(libdir)).<br>
<br>Is there any other reason for adding -L$(libdir) option?<br><br>regards,<div><div></div><div class="h5"><br><br><div class="gmail_quote">On Fri, May 15, 2009 at 6:54 PM, <span dir="ltr"><<a href="mailto:matsuu@gmail.com" target="_blank">matsuu@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">From: MATSUU Takuto <<a href="mailto:matsuu@gentoo.org" target="_blank">matsuu@gentoo.org</a>><br>
<br>
---<br>
mod_glusterfs/apache/2.2/src/Makefile.am | 2 +-<br>
1 files changed, 1 insertions(+), 1 deletions(-)<br>
<br>
diff --git a/mod_glusterfs/apache/2.2/src/Makefile.am b/mod_glusterfs/apache/2.2/src/Makefile.am<br>
index 1e8f3a3..b2b73dd 100644<br>
--- a/mod_glusterfs/apache/2.2/src/Makefile.am<br>
+++ b/mod_glusterfs/apache/2.2/src/Makefile.am<br>
@@ -7,7 +7,7 @@ all: mod_glusterfs.so<br>
<br>
mod_glusterfs.so: $(top_srcdir)/mod_glusterfs/apache/2.2/src/mod_glusterfs.c $(top_builddir)/libglusterfsclient/src/<a href="http://libglusterfsclient.la" target="_blank">libglusterfsclient.la</a><br>
ln -sf $(top_srcdir)/mod_glusterfs/apache/2.2/src/mod_glusterfs.c $(top_builddir)/mod_glusterfs/apache/2.2/src/mod_glusterfs-build.c<br>
- $(APXS) -c -o <a href="http://mod_glusterfs.la" target="_blank">mod_glusterfs.la</a> -Wc,-g3 -Wc,-O0 -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D__USE_FILE_OFFSET64 -I$(top_srcdir)/libglusterfsclient/src -L$(top_builddir)/libglusterfsclient/src/.libs/ -lglusterfsclient mod_glusterfs-build.c<br>
+ $(APXS) -c -o <a href="http://mod_glusterfs.la" target="_blank">mod_glusterfs.la</a> -Wc,-g3 -Wc,-O0 -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D__USE_FILE_OFFSET64 -I$(top_srcdir)/libglusterfsclient/src -L$(libdir) -L$(top_builddir)/libglusterfsclient/src/.libs/ -lglusterfsclient mod_glusterfs-build.c<br>
-ln -sf .libs/mod_glusterfs.so mod_glusterfs.so<br>
<br>
$(top_builddir)/libglusterfsclient/src/<a href="http://libglusterfsclient.la" target="_blank">libglusterfsclient.la</a>:<br>
--<br>
1.6.3<br>
<br>
<br>
<br>
_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@nongnu.org" target="_blank">Gluster-devel@nongnu.org</a><br>
<a href="http://lists.nongnu.org/mailman/listinfo/gluster-devel" target="_blank">http://lists.nongnu.org/mailman/listinfo/gluster-devel</a><br>
</blockquote></div><br><br clear="all"><br></div></div>-- <br><font color="#888888">Raghavendra G<br><br>
</font></div><br><br clear="all"><br>-- <br>Raghavendra G<br><br>