Hi Kirby,<br>Can you send patches against latest git repository ? <br><br>Procedure given here: <a href="http://gluster.org/docs/index.php/Development_Work_Flow">http://gluster.org/docs/index.php/Development_Work_Flow</a><br>
<br>We already have fix for (2), in a different way, which works now. <br><br>Thanks,<br>Amar<br><br><div class="gmail_quote">On Sun, Mar 15, 2009 at 4:00 AM, Kirby Zhou <span dir="ltr"><<a href="mailto:kirbyzhou@sohu-rd.com">kirbyzhou@sohu-rd.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div link="blue" vlink="purple" lang="ZH-CN">
<div>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">Some code reviews:</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US"> </span></p>
<p style="margin-left: 18pt; text-indent: -18pt;"><span style="color: rgb(31, 73, 125);" lang="EN-US"><span>1.<span style="font-family: "Times New Roman"; font-style: normal; font-variant: normal; font-weight: normal; font-size: 7pt; line-height: normal; font-size-adjust: none; font-stretch: normal;">
</span></span></span><u><span style="color: rgb(31, 73, 125);" lang="EN-US">./transport/socket/src/socket.c:socket_submit</span></u><span style="color: rgb(31, 73, 125);" lang="EN-US"> maybe conflict with <u>./xlators/protocol/client/src/client-protocol.c:protocol_client_xfer</u></span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US"> </span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">694
if (conn->connected ||</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">695
((type == GF_OP_TYPE_MOP_REQUEST) &&</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">696
(op == GF_MOP_SETVOLUME))) {</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">697
ret = transport_submit (trans, (char *)hdr, hdrlen,</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">698
vector,
count, refs);</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US"> </span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">1211
pthread_mutex_lock (&priv->lock);</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">1212
{</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">1213
if (priv->connected != 1) {</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">1214
if (!priv->submit_log && !priv->connect_finish_log) {</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">1215
gf_log (this->xl->name, GF_LOG_ERROR,</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">1216
"not connected (priv->connected = %d)",</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">1217
priv->connected);</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">1218
priv->submit_log = 1;</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">1219
}</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">1220
goto unlock;</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">1221
}</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US"> </span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">It seems if a socket
is not connected finally, <u>protocol_client_xfer</u> would try to submit GF_MOP_SETVOLUME,
but <u>socket_submit</u> would reject it.</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US"> </span></p>
<p style="margin-left: 18pt; text-indent: -18pt;"><span style="color: rgb(31, 73, 125);" lang="EN-US"><span>2.<span style="font-family: "Times New Roman"; font-style: normal; font-variant: normal; font-weight: normal; font-size: 7pt; line-height: normal; font-size-adjust: none; font-stretch: normal;">
</span></span></span><span style="color: rgb(31, 73, 125);" lang="EN-US">fetch-spec.c
seems broken.</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">if CHANNEL_BULK is
connected after CHANNEL_LOWLAT, the fetch_spec would exit incorrectly.</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US"> </span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">I have a patch here:</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US"> </span></p>
<p style="margin-left: 18pt; text-indent: -18pt;"><span style="color: rgb(31, 73, 125);" lang="EN-US"><span>3.<span style="font-family: "Times New Roman"; font-style: normal; font-variant: normal; font-weight: normal; font-size: 7pt; line-height: normal; font-size-adjust: none; font-stretch: normal;">
</span></span></span><span style="color: rgb(31, 73, 125);" lang="EN-US">mount.glusterfs
would hang if no augments are given</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US"> </span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">I also have a patch
here</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US"> </span></p>
<p style="margin-left: 18pt; text-indent: -18pt;"><span style="color: rgb(31, 73, 125);" lang="EN-US"><span>4.<span style="font-family: "Times New Roman"; font-style: normal; font-variant: normal; font-weight: normal; font-size: 7pt; line-height: normal; font-size-adjust: none; font-stretch: normal;">
</span></span></span><span style="color: rgb(31, 73, 125);" lang="EN-US">cannot
build on RHEL/CentOS/Fedora, the most popular RPM-based system. Because glusters
requires ‘apache-devel’, actually it would be ‘httpd-devel’</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US"> </span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">I also have a patch
here</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US"> </span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US"> </span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US"> </span></p>
<div>
<div style="border-style: solid none none; border-color: rgb(181, 196, 223) -moz-use-text-color -moz-use-text-color; border-width: 1pt medium medium; padding: 3pt 0cm 0cm;">
<p style="text-align: left;" align="left"><b><span style="font-size: 10pt;" lang="EN-US">From:</span></b><span style="font-size: 10pt;" lang="EN-US"> Kirby
Zhou [mailto:<a href="mailto:kirbyzhou@sohu-rd.com" target="_blank">kirbyzhou@sohu-rd.com</a>] <br>
<b>Sent:</b> Sunday, March 15, 2009 2:36 PM<br>
<b>To:</b> 'Kirby Zhou'; <a href="mailto:gluster-devel@nongnu.org" target="_blank">gluster-devel@nongnu.org</a><br>
<b>Subject:</b> RE: [Gluster-devel] glusterfs cannot get spec from remote.</span></p>
</div>
</div><div><div></div><div class="h5">
<p style="text-align: left;" align="left"><span lang="EN-US"> </span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US">Version 2.0.0rc4</span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US"> </span></p>
<p><span style="color: rgb(31, 73, 125);" lang="EN-US"> </span></p>
<div>
<div style="border-style: solid none none; border-color: rgb(181, 196, 223) -moz-use-text-color -moz-use-text-color; border-width: 1pt medium medium; padding: 3pt 0cm 0cm;">
<p style="text-align: left;" align="left"><b><span style="font-size: 10pt;" lang="EN-US">From:</span></b><span style="font-size: 10pt;" lang="EN-US">
gluster-devel-bounces+kirbyzhou=<a href="http://sohu-rd.com" target="_blank">sohu-rd.com</a>@<a href="http://nongnu.org" target="_blank">nongnu.org</a>
[mailto:<a href="mailto:gluster-devel-bounces%2Bkirbyzhou" target="_blank">gluster-devel-bounces+kirbyzhou</a>=<a href="http://sohu-rd.com" target="_blank">sohu-rd.com</a>@<a href="http://nongnu.org" target="_blank">nongnu.org</a>] <b>On Behalf Of
</b>Kirby Zhou<br>
<b>Sent:</b> Sunday, March 15, 2009 2:35 PM<br>
<b>To:</b> <a href="mailto:gluster-devel@nongnu.org" target="_blank">gluster-devel@nongnu.org</a><br>
<b>Subject:</b> [Gluster-devel] glusterfs cannot get spec from remote.</span></p>
</div>
</div>
<p style="text-align: left;" align="left"><span lang="EN-US"> </span></p>
<p><span lang="EN-US">For example:</span></p>
<p><span lang="EN-US"> </span></p>
<p><span lang="EN-US">[root@xen-727057 ~]# glusterfs --no-daemon
--volfile-server 10.10.123.21 --volfile-server-port 6986 /mnt</span></p>
<p><span lang="EN-US">error while getting volume file from server
10.10.123.21</span></p>
<p><span lang="EN-US">Try `glusterfs --help' or `glusterfs
--usage' for more information.</span></p>
<p><span lang="EN-US"> </span></p>
<p><span lang="EN-US">Using tcpdump to capture packages, there is
no requite to be sent:</span></p>
<p><span lang="EN-US"> </span></p>
<p><span lang="EN-US">[root@xen-727057 ~]# tcpdump tcp port 6986
-n</span></p>
<p><span lang="EN-US">tcpdump: verbose output suppressed, use -v
or -vv for full protocol decode</span></p>
<p><span lang="EN-US">listening on eth0, link-type EN10MB
(Ethernet), capture size 96 bytes</span></p>
<p><span lang="EN-US">14:31:22.584355 IP 10.10.63.202.1023 >
10.10.123.21.6986: S 2145611414:2145611414(0) win 5840 <mss
1460,sackOK,timestamp 230654970 0,nop,wscale 7></span></p>
<p><span lang="EN-US">14:31:22.584535 IP 10.10.123.21.6986 >
10.10.63.202.1023: S 2304819495:2304819495(0) ack 2145611415 win 5840 <mss
1460></span></p>
<p><span lang="EN-US">14:31:22.584569 IP 10.10.63.202.1023 >
10.10.123.21.6986: . ack 1 win 5840</span></p>
<p><span lang="EN-US">14:31:22.588027 IP 10.10.63.202.1022 >
10.10.123.21.6986: S 2148558987:2148558987(0) win 5840 <mss
1460,sackOK,timestamp 230654971 0,nop,wscale 7></span></p>
<p><span lang="EN-US">14:31:22.588208 IP 10.10.123.21.6986 >
10.10.63.202.1022: S 2307519548:2307519548(0) ack 2148558988 win 5840 <mss
1460></span></p>
<p><span lang="EN-US">14:31:22.588225 IP 10.10.63.202.1022 >
10.10.123.21.6986: . ack 1 win 5840</span></p>
<p><span lang="EN-US">14:31:22.588805 IP 10.10.63.202.1023 >
10.10.123.21.6986: F 1:1(0) ack 1 win 5840</span></p>
<p><span lang="EN-US">14:31:22.588827 IP 10.10.63.202.1022 >
10.10.123.21.6986: F 1:1(0) ack 1 win 5840</span></p>
<p><span lang="EN-US">14:31:22.589014 IP 10.10.123.21.6986 >
10.10.63.202.1022: F 1:1(0) ack 2 win 5840</span></p>
<p><span lang="EN-US">14:31:22.589026 IP 10.10.63.202.1022 >
10.10.123.21.6986: . ack 2 win 5840</span></p>
<p><span lang="EN-US">14:31:22.589187 IP 10.10.123.21.6986 >
10.10.63.202.1023: F 1:1(0) ack 2 win 5840</span></p>
<p><span lang="EN-US">14:31:22.589197 IP 10.10.63.202.1023 >
10.10.123.21.6986: . ack 2 win 5840</span></p>
<p><span lang="EN-US"> </span></p>
<p><span lang="EN-US"> </span></p>
<p><span lang="EN-US"> </span></p>
</div></div></div>
</div>
<br>_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@nongnu.org">Gluster-devel@nongnu.org</a><br>
<a href="http://lists.nongnu.org/mailman/listinfo/gluster-devel" target="_blank">http://lists.nongnu.org/mailman/listinfo/gluster-devel</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Amar Tumballi<br><br>