This is committed already (when we were using TLA). It caused problems with compilation on Mac OS X too.<br><br><div class="gmail_quote">2009/3/3 Anand Avati <span dir="ltr"><<a href="mailto:avati@zresearch.com">avati@zresearch.com</a>></span><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Can you please resubmit this with git format-patch, if still<br>
applicable on FreeBSD?<br>
<font color="#888888"><br>
Avati<br>
</font><div><div></div><div class="h5"><br>
On Tue, Feb 17, 2009 at 1:49 AM, Filipe Maia <<a href="mailto:filipe@xray.bmc.uu.se">filipe@xray.bmc.uu.se</a>> wrote:<br>
> Hi,<br>
><br>
> The previous patch does not compile in FreeBSD as I used a non<br>
> standard part of the stat structure.<br>
><br>
> Here's the fix against 2.0.0r18 to make it compile in FreeBSD (and<br>
> possibly other POSIX systems).<br>
><br>
> --- posix.c.orig 2009-02-16 21:10:36.963597828 +0100<br>
> +++ posix.c 2009-02-16 21:11:05.587603273 +0100<br>
> @@ -2864,8 +2864,8 @@<br>
> */<br>
><br>
> if (!S_ISLNK (entry->buf.st_mode)) {<br>
> - tv[0].tv_sec = entry->buf.st_atim.tv_sec;<br>
> - tv[1].tv_sec = entry->buf.st_mtim.tv_sec;<br>
> + tv[0].tv_sec = entry->buf.st_atime;<br>
> + tv[1].tv_sec = entry->buf.st_mtime;<br>
> ret = utimes (pathname, tv);<br>
> if (ret == -1) {<br>
> op_ret = -errno;<br>
><br>
> Filipe<br>
><br>
> On Sat, Jan 31, 2009 at 06:09, Anand Avati <<a href="mailto:avati@zresearch.com">avati@zresearch.com</a>> wrote:<br>
>> Committed (with some minor changes). Thanks! There is no sensible way<br>
>> to set ctime.<br>
>><br>
>> Avati<br>
>><br>
>> On Mon, Jan 26, 2009 at 9:48 PM, Filipe Maia <<a href="mailto:filipe@xray.bmc.uu.se">filipe@xray.bmc.uu.se</a>> wrote:<br>
>>> Hi,<br>
>>><br>
>>> When doing self heal the access and modification times are not<br>
>>> preserved. This can have bad consequences for certain applications<br>
>>> (e.g. make).<br>
>>> The attached patch tries to fix this.<br>
>>> It doesn't set ctime as is impossible to do in a portable way.<br>
>>><br>
>>> I also noticed that removing the namespace with glusterfsd running<br>
>>> results in glusterfsd getting confused. It has to be restarted for<br>
>>> things to go back to normal.<br>
>>> It would be nice to be able to avoid this.<br>
>>><br>
>>> Filipe<br>
>>><br>
>>> _______________________________________________<br>
>>> Gluster-devel mailing list<br>
>>> <a href="mailto:Gluster-devel@nongnu.org">Gluster-devel@nongnu.org</a><br>
>>> <a href="http://lists.nongnu.org/mailman/listinfo/gluster-devel" target="_blank">http://lists.nongnu.org/mailman/listinfo/gluster-devel</a><br>
>>><br>
>>><br>
>><br>
><br>
<br>
<br>
_______________________________________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@nongnu.org">Gluster-devel@nongnu.org</a><br>
<a href="http://lists.nongnu.org/mailman/listinfo/gluster-devel" target="_blank">http://lists.nongnu.org/mailman/listinfo/gluster-devel</a><br>
<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Amar Tumballi<br><br>