[Gluster-devel] EXPECT_WITHIN output change

Pranith Kumar Karampuri pkarampu at redhat.com
Wed Jul 9 09:44:22 UTC 2014


hi,
I sent the following patch to change the output of EXPECT_WITHIN:
http://review.gluster.org/8263

Patch got one +1 and regressions passed. Merge it please :-).

Test:
#!/bin/bash

. $(dirname $0)/../include.rc

EXPECT_WITHIN 10 "abc" echo "def"
EXPECT_WITHIN 10 "def" echo "def"
EXPECT_WITHIN 10 "abc" ls asjfrhg



Old-style-output:
===============================
15:10:03 :) ⚡ prove -rfv tests/basic/self-heald-test.t
tests/basic/self-heald-test.t ..
1..3
not ok 1
FAILED COMMAND: abc echo def
ok 2
ls: cannot access asjfrhg: No such file or directory
not ok 3
FAILED COMMAND: abc ls asjfrhg
Failed 2/3 subtests

Test Summary Report
-------------------
tests/basic/self-heald-test.t (Wstat: 0 Tests: 3 Failed: 2)
Failed tests: 1, 3

====================================

New-style-output:
====================================
root at pranithk-laptop - /home/pk1/workspace/gerrit-repo (master)
15:10:21 :( ⚡ prove -rfv tests/basic/self-heald-test.t
tests/basic/self-heald-test.t ..
1..3
not ok 1 Got "def" instead of "abc"
FAILED COMMAND: abc echo def
ok 2
ls: cannot access asjfrhg: No such file or directory
not ok 3 Got "" instead of "abc"
FAILED COMMAND: abc ls asjfrhg
Failed 2/3 subtests

Test Summary Report
-------------------
tests/basic/self-heald-test.t (Wstat: 0 Tests: 3 Failed: 2)
Failed tests: 1, 3

Pranith


More information about the Gluster-devel mailing list